I still doubt that the Mueller investigation will sink him, but I now expect the numerous accusations of affairs to keep him from being reelected. That kind of stuff is just a really easy way to lower enthusiasm among the social conservatives that had to hold their nose to vote for him the last time. Celebrity locker room talk was bad enough. Now you've got porn stars and playmates making what appear to be credible accusations of affairs while his wife was pregnant or had just delivered. I spend a lot of time around a pretty socially conservative crowd. A lot of the men and most of the women who were still supporting him a few months ago are awfully quiet about politics these days.
I don't know Jaw, the-squared may be onto something but I think he's overlooking a few things too. Short term Trump should be more popular because of the extra money in peoples' paychecks though this is never going to be the amount they probably expected. Still more is better than less. IF and I still that's a big IF, the economy really takes off rather than just sputters upwards like it has been so far he may well get re-elected. I stated a few weeks ago with less than stellar response I might add, that his contributions to get the economy really booming were more about smoke, mirrors, and BS. Cut regulations, lower taxes, etc., sound good to big business but there were never enough specifics to satisfy a cynic like me. IMO this current up-ish turn is more about those with money to go through short term gyrations to get more money and then go back into their holes until they're positive things are way better. I would liken it to a hurricane passing over, you hunker down (2007-2017), come out when the eye passes over, try to replenish your supplies, then you get back into your shelter when you think the other 1/2 of the storm is about to hit and get ready to ride the rest of it out.
What will/might get him re-elected? A noticeably better economy for a longer period of time could do the trick. All this impeachment stuff can very well turn around and help him too just like it did Bill and even they were trying to hang something around Obama's neck. A war might help too, IF we can for sure make ourselves be pictured as the attacked party rather than the attacking party. Otherwise that could seriously backfire.
As for the morality charges, I know this will PO the Repubs around here, but they sold out for Trump knowing his 1,000,001 character/morality flaws already. It's too late for any non-dedicated Repub voter to all of a sudden realize he's a moral and ethical slime ball and offensive to those who truly care about their faith, rather than what talk-radio preaches about their faith. You know even St. Peter wept bitterly when he realized what he had done. They, along with a LOT of indies elected a morally and ethnically bankrupt carnival barker/reality TV host because he promised to get the economy going/booming, bring the jobs back, bring the investments back, and nominate SCOTUS justices they liked/wanted. As long as he keeps doing this, they'll just have to hold their noses and vote for him again or admit they were wrong and you know that ain't gonna happen.
If the economy tanks again or we are the aggressors in a war, or no more SCOTUS justices retire or die he might be in trouble. At some point the Repub leaders in Congress like McConnell and Ryan, who personally I think are way bigger slime balls than Trump will probably turn on him, once they get the stuff they wanted passed by his efforts, and once they start seeing him as a liability in 2020 rather than as an asset. Again as long as the "Crazy Train, to plagiarize Ozzy" keeps rolling so will he, but it just doesn't take that much to get it off the tracks and once that happens......
If memory serves President GHW Bush (41) had approval rating right at 90% right after the Gulf War, less than 2 years later he lost to Slick Willy. Politics are more fickle than NFL officials and Roger Goodell and his sense of justice. Only time will tell IMO.