Perception really doesn't change it too much. Sure it didn't wind up being a complete and total W for the Braves. We knew Infante would do well there, but this is the first year that Omar has for sure outplayed Uggla, and Mike Dunn is a reliever, him being on the team would only have meant longer wait for guys like Avilan and Wood to get their shots.
We traded 1 year of Infante and a reliever for Uggla, it was a smart trade, wound up that we were on the losing end of the trade in the end, but heck that can happen. Same deal as the McLouth trade. Pittsburgh seems like they now have the better end since Locke is doing well, but at the time it was a no brainer. Sometimes you get shocking wins, sometimes you get no brainer wins (Horacio for Soriano) sometimes you get risky wins or losses, sometimes you get no brainers that turn to losses. If you can go back in time, you still would make the McLouth and Uggla trades because the odds of them collapsing as hard as they did (and in reality until this year Uggla didn't collapse) is slimmer than the odds they'll maintain.
Some trades you can look back on and wonder if they're worth it, JD Drew being one (I think JS foolishly assumed that Drew would take a discount to stay in Atlanta as a Georgia native), LaRoche leaving Atlanta being arguably the biggest (leading to the infamous Teixeira trade, but if we had LaRoche we don't make that trade anyway) then of course seperate from the LaRoche trade, why make that move when we had other holes as well. And then of course the shipping off Teixeira the following season.
I mean to be honest if we weren't a not very good team the Tex trade could be viewed in a different light. He rocked for us in the second half of 2007 and basically in his year with Atlanta hit basically .300/.400/.550 cannot complain about that at all, but as a not great team it was a bad move.